Allow disabling time auto-advance behavior in tests #5200
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4522. See that issue for a more extensive approach.
Motivation
Some programs have background tests that use sleeping for timings while working with IO. Testing such programs with auto-advancing time is currently quite complicated, as it's not possilbe to time the IO correctly..
Solution
This PR adds a way to disable the auto-advance behavior, so that tests can directly manage time using
time::advance
. It's simply a boolean flag, which is checked when time would be auto-advanced otherwise.