Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add ability to disable paused clock auto-advance #4523

Conversation

sjoerdsimons
Copy link

Motivation

In some cases one might want to stop the clock from auto-advancing to
allow I/O happen before timers expire.

Solution

Add an no advance mode to pausing
which can be enabled/disabled to support this mode

fixes #4522

In some cases one might want to stop the clock from auto-advancing to
allow I/O happen before timers expire. Add an no advance mode to pausing
which can be enabled/disabled to support this mode of operation

fixes tokio-rs#4522
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Feb 21, 2022
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-time Module: tokio/time labels Feb 23, 2022
@Darksonn
Copy link
Contributor

Since this has been stale for months and marked as "not ready for review", I will close it. Feel free to reopen if you make further progress.

@Darksonn Darksonn closed this Jun 30, 2022
@sjoerdsimons
Copy link
Author

@Darksonn The reason it is this state still is that i'm waiting on feedback on #4522 to see where to potentially take it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-time Module: tokio/time R-loom Run loom tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to (temporarily) disable time auto-advance when paused
2 participants