Use `[lints.rust.unexpected_cfgs.check-cfg]` instead of hacky check-cfg workaround

[Urgau]

With the release of rust-lang/cargo#13913 (in nightly-2024-05-19), there is no longer any need for the kind of workarounds employed in #6538. Cargo has gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]¹:

Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(foo)'] }

Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.

Originally posted by @Urgau in #6538 (comment)

Footnotes

1. take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below ↩

[Darksonn]

Will this work on our MSRV of Rust 1.63?

[Urgau]

There is no reason it wouldn't. The feature is only active with Rust 1.80.
And while [lints.rust.unexpected_cfgs.check-cfg] produces a unused warning for Rust 1.78 and below, it is only present in local development, thanks to a --cap-lints-like system in Cargo.

[taiki-e]

This is not blocked on MSRV.

On older versions, Cargo just outputting a warning that is not promoted to an error as well as the rust-version field.

warning: /home/runner/work/tokio/tokio/Cargo.toml: unused manifest key: workspace.lints.rust.unexpected_cfgs.check-cfg