Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budgeting for IO resources should not just apply to async_io based operations #6237

Open
Darksonn opened this issue Dec 20, 2023 · 0 comments
Assignees
Labels
A-tokio Area: The main tokio crate M-coop Module: tokio/coop M-net Module: tokio/net

Comments

@Darksonn
Copy link
Contributor

In #6221, we introduced a change that introduces coop budgeting to anything that uses tokio::runtime::io::registration::async_io. However, this does not cover all ways of using sockets. We should expand this to cover all ways of using sockets with the following mechanism:

  • Polling for readiness returns Pending on missing coop budget, but does not consume budget.
  • IO operations, even non-async ones, consume a budget, but do not check it.

See also this conversation.

Cc: #5946, #4782.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net M-coop Module: tokio/coop labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-coop Module: tokio/coop M-net Module: tokio/net
Projects
None yet
Development

No branches or pull requests

2 participants