WIP: make deriving Debug optional #367
Closed
+66
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #334 by allowing users to opt-out of having prost derive Debug for its structs.
prost_build::Config
gains ano_derive_dbg(bool)
method for users to use. this inserts a#[prost(no_dbg)]
attribute on the generated struct.Message
change fromDebug + Send + Sync
to justSend + Sync
.The default behavior is opt-out, so it breaks nothing for current users.
WIP because still need to adjust docs, but wanted to see if this is acceptable.