Use std::os::unix::net::SocketAddr instead of mio::net::SocketAddr

[Thomasdezeeuw]

It's the same type. It's only implemented by us because we can't create std::os::unix::net::SocketAddr.

[Thomasdezeeuw]

We can do this in 1.61.

[Noah-Kennedy]

@Thomasdezeeuw is it confirmed to be stabilizing then?

[Thomasdezeeuw]

@Noah-Kennedy it's stabilised in rust-lang/rust#94356.

[RealXuChe]

From #1605, I want to notice you that there may be a regression in the replacement: As you can see here, std::os::unix::net::SocketAddr doesn't support binding to a path with \0 in it, which means it doesn't support abstract Unix socket.

Of course, there's no reason for std::os::unix::net::SocketAddr to support abstract Unix socket, since abstract Unix socket is a Linux feature, and not in the Unix spec.

But mio has already supported abstract Unix socket, though it's a little buggy, like there's no conditional compilation to make it only work on Linux.

So this replacement will possibly break the use of abstract Unix socket, I think we need to be careful on this.

(Sorry for my bad English)

[Thomasdezeeuw]

I think the support is still unstable, but it's should come at some point: https://doc.rust-lang.org/std/os/unix/net/struct.SocketAddr.html#method.from_abstract_namespace. Maybe we can create a pr to stabilise it.

[gustav3d]

That's a good idea indeed.

…

On Tue, 30 Aug 2022 at 20:09, Thomas de Zeeuw ***@***.***> wrote: I think the support is still unstable, but it's should come at some point: https://doc.rust-lang.org/std/os/unix/net/struct.SocketAddr.html#method.from_abstract_namespace. Maybe we can create a pr to stabilise it. — Reply to this email directly, view it on GitHub <#1527 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABCY4MXA6BK2ZDAP4M3UPTV3ZE6VANCNFSM5HQUHSUQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>