Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Getting started - Hello world #73

Open
LeReunionais opened this issue Oct 13, 2018 · 5 comments
Open

Feedback - Getting started - Hello world #73

LeReunionais opened this issue Oct 13, 2018 · 5 comments
Assignees

Comments

@LeReunionais
Copy link

  • Where to add dependencies
    It's a tiny feedback but I think it would be nice to add in which file to add the dependencies:
    Something like:

Next, add the necessary dependencies in Cargo.toml:

[dependencies]
tokio = "0.1"
  • Add a section at the end to run the example:
  1. Start a tcp server: nc -p 6142
  2. Run: cargo run
  3. What to expect
About to create the stream and write to it...
created stream
wrote to stream; success=true
Stream has been created and written to.
@carllerche
Copy link
Member

Looks good to me!

cc @rylev I think this would be applied to your section.

@mziter
Copy link

mziter commented Feb 2, 2019

Running the following command per current docs gives me Connection refused error
nc -l 6142
I needed to run the following for the example to succeed
nc -l -p 6142

I would be happy to update once someone confirms that current docs are innacurate

@mziter
Copy link

mziter commented Feb 2, 2019

PR in for requested change above: tokio-rs/website#283

@mziter
Copy link

mziter commented Feb 2, 2019

Closed PR. Looks like my issue was with the version of netcat I was using. What are people's thoughts on adding an info or warning section about possible version issues. I originally discovered this because I got an error about the connection being refused, which might put off users.

@carllerche
Copy link
Member

Right, we probably should move away from using netcat here given how there are differences across platforms.

Does anyone have ideas on an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants