Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace unmaintained actions-rs/* actions in CI workflows #436

Merged
merged 1 commit into from
Jun 10, 2023
Merged

chore: replace unmaintained actions-rs/* actions in CI workflows #436

merged 1 commit into from
Jun 10, 2023

Conversation

striezel
Copy link
Contributor

Basically all of the actions-rs/* actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/tokio-rs/console/actions/runs/5149949330:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

To get rid of those warnings the occurrences of actions-rs/toolchain are replaced by dtolnay/rust-toolchain, and the occurrences of actions-rs/cargo are replaced by direct invocations of cargo.

@striezel
chore: replace unmaintained actions-rs/* actions in CI workflows
3c84e25 
Basically all of the `actions-rs/*` actions are unmaintained. See
<actions-rs/toolchain#216> for more
information. Due to their age they generate several warnings in
CI runs.

To get rid of those warnings the occurrences of
`actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`,
and the occurrences of `actions-rs/cargo` are replaced by direct
invocations of `cargo`.
@striezel striezel requested a review from a team as a code owner June 10, 2023 06:58
@hawkw hawkw enabled auto-merge (squash) June 10, 2023 13:46
hawkw
hawkw approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great!

@hawkw hawkw merged commit 9107562 into tokio-rs:main Jun 10, 2023
@striezel striezel deleted the actions-rs-replacements branch June 11, 2023 17:56
@striezel striezel mentioned this pull request Jun 11, 2023
Merged
hawkw pushed a commit that referenced this pull request Sep 29, 2023
@striezel @hawkw
chore: replace unmaintained actions-rs/* actions in CI workflows (#436)
cd1a277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@striezel @hawkw