fix(subscriber): fix off-by-one indexing for callsites (#391)

danielhenrymantilla · hawkw · hawkw · commit 43891aba0a42 · 2023-09-29T09:39:19.000-07:00
Co-authored-by: Eliza Weisman &lt;eliza@buoyant.io&gt;
diff --git a/console-subscriber/src/callsites.rs b/console-subscriber/src/callsites.rs
@@ -23,7 +23,7 @@ impl<const MAX_CALLSITES: usize> Callsites<MAX_CALLSITES> {
         }
 
         let idx = self.len.fetch_add(1, Ordering::AcqRel);
-        if idx <= MAX_CALLSITES {
+        if idx < MAX_CALLSITES {
             // If there's still room in the callsites array, stick the address
             // in there.
             self.ptrs[idx]

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ impl<const MAX_CALLSITES: usize> Callsites<MAX_CALLSITES> {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`let idx = self.len.fetch_add(1, Ordering::AcqRel);`
`26`		`- if idx <= MAX_CALLSITES {`
	`26`	`+ if idx < MAX_CALLSITES {`
`27`	`27`	`// If there's still room in the callsites array, stick the address`
`28`	`28`	`// in there.`
`29`	`29`	`self.ptrs[idx]`