Depend on serde_core instead of serde
#797
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Sep 14, 2025
DaniPopes
force-pushed
the
serde_core
branch
from
579784e to
dcd6fe7
Compare
|
CI |
|
Maybe the old version resolver wasn't as smart as the new one. Does it work locally if you let a more modern version (but not too modern that it uses the newer Cargo.lock format) generate the lockfile? |
This crate does not make use of serde derive macros, thus it can depend on `serde_core` instead of `serde` to speed up users' compile times. See the documentation of [`serde_core`](https://docs.rs/serde_core) for more details.
DaniPopes
force-pushed
the
serde_core
branch
from
dcd6fe7 to
16a496a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate does not make use of serde derive macros, thus it can depend on
serde_coreinstead ofserdeto speed up users' compile times.See the documentation of
serde_corefor more details.Note that this adds a hiddenserde_corefeature, since we cannot use thedep:syntax when declaring theserdefeature due to this crate's MSRV being lower than the required 1.60.