Skip to content

Commit fd0ce07

Browse files
committed
Rename UninitSlice constructors for consistency with ReadBuf
tokio::io::ReadBuf uses names `new` and `uninit` for its constructors. For consistency with that, rename recently introduced UninitSlice constructors to match those names.
1 parent b29112c commit fd0ce07

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/buf/buf_mut.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1427,7 +1427,7 @@ unsafe impl BufMut for &mut [core::mem::MaybeUninit<u8>] {
14271427

14281428
#[inline]
14291429
fn chunk_mut(&mut self) -> &mut UninitSlice {
1430-
UninitSlice::from_uninit_slice(self)
1430+
UninitSlice::uninit(self)
14311431
}
14321432

14331433
#[inline]

src/buf/uninit_slice.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ impl UninitSlice {
3131
/// use core::mem::MaybeUninit;
3232
///
3333
/// let mut buffer = [MaybeUninit::uninit(); 64];
34-
/// let slice = UninitSlice::from_uninit_slice(&mut buffer[..]);
34+
/// let slice = UninitSlice::uninit(&mut buffer[..]);
3535
///
3636
/// let mut vec = Vec::with_capacity(1024);
3737
/// let spare: &mut UninitSlice = vec.spare_capacity_mut().into();
3838
/// ```
3939
#[inline]
40-
pub fn from_uninit_slice(slice: &mut [MaybeUninit<u8>]) -> &mut UninitSlice {
40+
pub fn uninit(slice: &mut [MaybeUninit<u8>]) -> &mut UninitSlice {
4141
unsafe { &mut *(slice as *mut [MaybeUninit<u8>] as *mut UninitSlice) }
4242
}
4343

44-
fn from_uninit_slice_ref(slice: &[MaybeUninit<u8>]) -> &UninitSlice {
44+
fn uninit_ref(slice: &[MaybeUninit<u8>]) -> &UninitSlice {
4545
unsafe { &*(slice as *const [MaybeUninit<u8>] as *const UninitSlice) }
4646
}
4747

@@ -53,10 +53,10 @@ impl UninitSlice {
5353
/// use bytes::buf::UninitSlice;
5454
///
5555
/// let mut buffer = [0u8; 64];
56-
/// let slice = UninitSlice::from_slice(&mut buffer[..]);
56+
/// let slice = UninitSlice::new(&mut buffer[..]);
5757
/// ```
5858
#[inline]
59-
pub fn from_slice(slice: &mut [u8]) -> &mut UninitSlice {
59+
pub fn new(slice: &mut [u8]) -> &mut UninitSlice {
6060
unsafe { &mut *(slice as *mut [u8] as *mut [MaybeUninit<u8>] as *mut UninitSlice) }
6161
}
6262

@@ -82,7 +82,7 @@ impl UninitSlice {
8282
pub unsafe fn from_raw_parts_mut<'a>(ptr: *mut u8, len: usize) -> &'a mut UninitSlice {
8383
let maybe_init: &mut [MaybeUninit<u8>] =
8484
core::slice::from_raw_parts_mut(ptr as *mut _, len);
85-
Self::from_uninit_slice(maybe_init)
85+
Self::uninit(maybe_init)
8686
}
8787

8888
/// Write a single byte at the specified offset.
@@ -215,13 +215,13 @@ impl fmt::Debug for UninitSlice {
215215

216216
impl<'a> From<&'a mut [u8]> for &'a mut UninitSlice {
217217
fn from(slice: &'a mut [u8]) -> Self {
218-
UninitSlice::from_slice(slice)
218+
UninitSlice::new(slice)
219219
}
220220
}
221221

222222
impl<'a> From<&'a mut [MaybeUninit<u8>]> for &'a mut UninitSlice {
223223
fn from(slice: &'a mut [MaybeUninit<u8>]) -> Self {
224-
UninitSlice::from_uninit_slice(slice)
224+
UninitSlice::uninit(slice)
225225
}
226226
}
227227

@@ -233,14 +233,14 @@ macro_rules! impl_index {
233233

234234
#[inline]
235235
fn index(&self, index: $t) -> &UninitSlice {
236-
UninitSlice::from_uninit_slice_ref(&self.0[index])
236+
UninitSlice::uninit_ref(&self.0[index])
237237
}
238238
}
239239

240240
impl IndexMut<$t> for UninitSlice {
241241
#[inline]
242242
fn index_mut(&mut self, index: $t) -> &mut UninitSlice {
243-
UninitSlice::from_uninit_slice(&mut self.0[index])
243+
UninitSlice::uninit(&mut self.0[index])
244244
}
245245
}
246246
)*

0 commit comments

Comments
 (0)