Remove "required" for currency precision to allow zero precision.

Author: KarlTheProgrammer

cmd/tokenized/cmd/cmd_decode.go

@@ -20,6 +20,17 @@ var cmdDecode = &cobra.Command{
 			return errors.New("Wrong argument count : requires 1")
 		}
 
+		if len(args[0]) > 2 && args[0][0] == '0' && args[0][1] == 'x' {
+			b, hexErr := hex.DecodeString(args[0][2:])
+			if hexErr == nil {
+				if err := print.PrintBytes(b); err != nil {
+					return errors.Wrap(err, "decode")
+				}
+
+				return nil
+			}
+		}
+
 		b, hexErr := hex.DecodeString(args[0])
 		if hexErr == nil {
 			if err := print.PrintBytes(b); err != nil {

dist/golang/instruments/validate.go

@@ -530,9 +530,6 @@ func (a *CurrencyValueField) Validate() error {
 	if a.Precision > uint32(max1ByteInteger) {
 		return fmt.Errorf("Precision over max value : %d > %d", a.Precision, max1ByteInteger)
 	}
-	if a.Precision == 0 {
-		return fmt.Errorf("Precision required")
-	}
 
 	return nil
 }
@@ -573,9 +570,6 @@ func (a *FixedCurrencyValueField) Validate() error {
 	if a.Precision > uint32(max1ByteInteger) {
 		return fmt.Errorf("Precision over max value : %d > %d", a.Precision, max1ByteInteger)
 	}
-	if a.Precision == 0 {
-		return fmt.Errorf("Precision required")
-	}
 
 	return nil
 }

dist/json/instruments.json

@@ -73,11 +73,10 @@
           "type": "CurrencyType"
         },
         {
-          "description": "Required field to specify the decimal precision of the value. It will normally be the  \"precision\" value associated with the Currency. It is the number of decimal places between  the number of tokens and the common unit of measure. For example, in AUD, the common unit is  the dollar, but a token would only be worth a penny. So the precision should be 2 for the  two decimal places in a dollar amount \"$1.00\". In this scenario 100 tokens are worth $1.\n",
+          "description": "Specify the decimal precision of the value. It will normally be the \"precision\" value associated with the Currency. It is the number of decimal places between the number of tokens and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token would only be worth a penny. So the precision should be 2 for the two decimal places in a dollar amount \"$1.00\". In this scenario 100 tokens are worth $1. Zero is assumed if no value is specified.\n",
           "example": 2,
           "label": "Precision",
           "name": "Precision",
-          "required": true,
           "size": 1,
           "type": "uint"
         }
@@ -109,11 +108,10 @@
           "type": "CurrencyType"
         },
         {
-          "description": "Required field to specify the decimal precision of the value. It will normally be the \"precision\" value associated with the Currency. It is the number of decimal places between the number of tokens and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token would only be worth a penny. So the precision should be 2 for the two decimal places in a dollar amount \"$1.00\". In this scenario 100 tokens are worth $1.\n",
+          "description": "Specify the decimal precision of the value. It will normally be the \"precision\" value associated with the Currency. It is the number of decimal places between the number of tokens and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token would only be worth a penny. So the precision should be 2 for the two decimal places in a dollar amount \"$1.00\". In this scenario 100 tokens are worth $1. Zero is assumed if no value is specified.\n",
           "example": 2,
           "label": "Precision",
           "name": "Precision",
-          "required": true,
           "size": 1,
           "type": "uint"
         }

dist/markdown/protocol-instruments.md

@@ -1234,9 +1234,9 @@ A value specified in terms of a currency.
             uint(1)
         </td>
         <td>
-            Required field to specify the decimal precision of the value. It will normally be the  &#34;precision&#34; value associated with the Currency. It is the number of decimal places between  the number of tokens and the common unit of measure. For example, in AUD, the common unit is  the dollar, but a token would only be worth a penny. So the precision should be 2 for the  two decimal places in a dollar amount &#34;$1.00&#34;. In this scenario 100 tokens are worth $1.
+            Specify the decimal precision of the value. It will normally be the &#34;precision&#34; value associated with the Currency. It is the number of decimal places between the number of tokens and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token would only be worth a penny. So the precision should be 2 for the two decimal places in a dollar amount &#34;$1.00&#34;. In this scenario 100 tokens are worth $1. Zero is assumed if no value is specified.
 
-             This field is always required.  Example: 2
+             Example: 2
         </td>
     </tr>
 
@@ -1286,9 +1286,9 @@ A fixed value specified in terms of a currency. The &#34;Value&#34; must be 1. T
             uint(1)
         </td>
         <td>
-            Required field to specify the decimal precision of the value. It will normally be the &#34;precision&#34; value associated with the Currency. It is the number of decimal places between the number of tokens and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token would only be worth a penny. So the precision should be 2 for the two decimal places in a dollar amount &#34;$1.00&#34;. In this scenario 100 tokens are worth $1.
+            Specify the decimal precision of the value. It will normally be the &#34;precision&#34; value associated with the Currency. It is the number of decimal places between the number of tokens and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token would only be worth a penny. So the precision should be 2 for the two decimal places in a dollar amount &#34;$1.00&#34;. In this scenario 100 tokens are worth $1. Zero is assumed if no value is specified.
 
-             This field is always required.  Example: 2
+             Example: 2
         </td>
     </tr>
 

dist/swagger/instruments/CurrencyValueField.yaml

@@ -14,11 +14,12 @@ properties:
     example: "AUD"
   Precision:
     description:  >
-      Required field to specify the decimal precision of the value. It will normally be the 
-      "precision" value associated with the Currency. It is the number of decimal places between  the
-      number of tokens and the common unit of measure. For example, in AUD, the common unit is  the
-      dollar, but a token would only be worth a penny. So the precision should be 2 for the  two
-      decimal places in a dollar amount "$1.00". In this scenario 100 tokens are worth $1.
+      Specify the decimal precision of the value. It will normally be the "precision" value
+      associated with the Currency. It is the number of decimal places between the number of tokens
+      and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token
+      would only be worth a penny. So the precision should be 2 for the two decimal places in a
+      dollar amount "$1.00". In this scenario 100 tokens are worth $1. Zero is assumed if no value is
+      specified.
     type: number
     example: 2
 

dist/swagger/instruments/FixedCurrencyValueField.yaml

@@ -16,11 +16,12 @@ properties:
     example: "AUD"
   Precision:
     description:  >
-      Required field to specify the decimal precision of the value. It will normally be the
-      "precision" value associated with the Currency. It is the number of decimal places between the
-      number of tokens and the common unit of measure. For example, in AUD, the common unit is the
-      dollar, but a token would only be worth a penny. So the precision should be 2 for the two
-      decimal places in a dollar amount "$1.00". In this scenario 100 tokens are worth $1.
+      Specify the decimal precision of the value. It will normally be the "precision" value
+      associated with the Currency. It is the number of decimal places between the number of tokens
+      and the common unit of measure. For example, in AUD, the common unit is the dollar, but a token
+      would only be worth a penny. So the precision should be 2 for the two decimal places in a
+      dollar amount "$1.00". In this scenario 100 tokens are worth $1. Zero is assumed if no value is
+      specified.
     type: number
     example: 2
 

src/instruments/develop/types/CurrencyValue.yaml

@@ -26,12 +26,12 @@ fields:
   - name: Precision
     label: Precision
     description: >
-        Required field to specify the decimal precision of the value. It will normally be the 
-        "precision" value associated with the Currency. It is the number of decimal places between 
-        the number of tokens and the common unit of measure. For example, in AUD, the common unit is 
-        the dollar, but a token would only be worth a penny. So the precision should be 2 for the 
-        two decimal places in a dollar amount "$1.00". In this scenario 100 tokens are worth $1.
+        Specify the decimal precision of the value. It will normally be the "precision" value
+        associated with the Currency. It is the number of decimal places between the number of
+        tokens and the common unit of measure. For example, in AUD, the common unit is the dollar,
+        but a token would only be worth a penny. So the precision should be 2 for the two decimal
+        places in a dollar amount "$1.00". In this scenario 100 tokens are worth $1. Zero is assumed
+        if no value is specified.
     type: uint
-    required: true
     size: 1
     example: 2

src/instruments/develop/types/FixedCurrencyValue.yaml

@@ -31,12 +31,12 @@ fields:
   - name: Precision
     label: Precision
     description: >
-        Required field to specify the decimal precision of the value. It will normally be the
-        "precision" value associated with the Currency. It is the number of decimal places between
-        the number of tokens and the common unit of measure. For example, in AUD, the common unit is
-        the dollar, but a token would only be worth a penny. So the precision should be 2 for the
-        two decimal places in a dollar amount "$1.00". In this scenario 100 tokens are worth $1.
+        Specify the decimal precision of the value. It will normally be the "precision" value
+        associated with the Currency. It is the number of decimal places between the number of
+        tokens and the common unit of measure. For example, in AUD, the common unit is the dollar,
+        but a token would only be worth a penny. So the precision should be 2 for the two decimal
+        places in a dollar amount "$1.00". In this scenario 100 tokens are worth $1. Zero is assumed
+        if no value is specified.
     type: uint
-    required: true
     size: 1
     example: 2