Remove name from CRN Credit Note.

Author: KarlTheProgrammer

dist/golang/instruments/amendments.go

@@ -1804,7 +1804,7 @@ func (a *InformationServiceLicense) CreateAmendments(fip permissions.FieldIndexP
 
 // CreditNote Permission / Amendment Field Indices
 const (
-	CreditNoteFieldName                = uint32(1)
+	DeprecatedCreditNoteFieldName      = uint32(1)
 	CreditNoteFieldFaceValue           = uint32(2)
 	CreditNoteFieldExpirationTimestamp = uint32(3)
 	CreditNoteFieldTransfersPermitted  = uint32(4)
@@ -1821,9 +1821,7 @@ func (a *CreditNote) ApplyAmendment(fip permissions.FieldIndexPath, operation ui
 	}
 
 	switch fip[0] {
-	case CreditNoteFieldName: // string
-		a.Name = string(data)
-		return permissions.SubPermissions(fip, operation, false)
+	case DeprecatedCreditNoteFieldName: // deprecated
 
 	case CreditNoteFieldFaceValue: // FixedCurrencyValueField
 		if len(fip) == 1 && len(data) == 0 {
@@ -1880,14 +1878,7 @@ func (a *CreditNote) CreateAmendments(fip permissions.FieldIndexPath,
 	var result []*internal.Amendment
 	ofip := fip.Copy() // save original to be appended for each field
 
-	// Name string
-	fip = append(ofip, CreditNoteFieldName)
-	if a.Name != newValue.Name {
-		result = append(result, &internal.Amendment{
-			FIP:  fip,
-			Data: []byte(newValue.Name),
-		})
-	}
+	// deprecated Name deprecated
 
 	// FaceValue FixedCurrencyValueField
 	fip = append(ofip, CreditNoteFieldFaceValue)

dist/golang/instruments/copy.go

@@ -295,9 +295,6 @@ func (a *CreditNote) Copy() *CreditNote {
 
 	result := &CreditNote{}
 
-	// Field Name - varchar
-	result.Name = a.Name
-
 	// Field FaceValue - FixedCurrencyValue
 	result.FaceValue = a.FaceValue.Copy()
 

dist/golang/instruments/equal.go

@@ -531,11 +531,6 @@ func (l *CreditNote) Equal(right proto.Message) bool {
 		return false
 	}
 
-	// Field Name - varchar
-	if c.Name != r.Name {
-		return false // fmt.Errorf("Name string mismatched")
-	}
-
 	// Field FaceValue - FixedCurrencyValue
 	if !c.FaceValue.Equal(r.FaceValue) {
 		return false // fmt.Errorf("FaceValue : %s", err)

dist/golang/instruments/instruments.pb.go

@@ -444,11 +444,6 @@ func (a *CreditNote) Validate() error {
 		return errors.New("Empty")
 	}
 
-	// Field Name - varchar
-	if len(a.Name) > max1ByteInteger {
-		return fmt.Errorf("Name over max size : %d > %d", len(a.Name), max1ByteInteger)
-	}
-
 	// Field FaceValue - FixedCurrencyValue
 	if err := a.FaceValue.Validate(); err != nil {
 		return errors.Wrap(err, "FaceValue")

dist/golang/instruments/validate.go

@@ -839,7 +839,7 @@
         {
           "label": "Name",
           "name": "Name",
-          "type": "varchar",
+          "type": "deprecated",
           "varSize": "tiny"
         },
         {

dist/json/instruments.json

@@ -1017,10 +1017,8 @@ A credit for a specified value in currency.
         <th>Description</th>
     </tr>
     <tr>
-        <td>Name</td>
-        <td>
-            varchar(tiny)
-        </td>
+        <td>(Deprecated)Name</td>
+        <td>deprecated</td>
         <td>
             
             

dist/markdown/protocol-instruments.md

@@ -119,7 +119,7 @@ message InformationServiceLicense {
 
 // Message - Credit Note (CRN)
 message CreditNote {
-    string Name                                    = 1;   // varchar
+    reserved                                         1;   // Deprecated Name
     FixedCurrencyValueField FaceValue              = 2;   // FixedCurrencyValue
     uint64 ExpirationTimestamp                     = 3;   // Timestamp
     bool TransfersPermitted                        = 4;   // bool