Update docs to express angles are in radians #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point, gl-matrix's documentation and function parameter names were a bit inconsistent here. Thanks for the PR, merged! 😄 (The Travis CI failure seems to be unrelated.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality changes, but some function inputs were renamed to match the usage in other classes, and the jsdoc updated to match.
I lost an hour of debugging because it wasn't explicit in the docs that vec2/vec3 rotations were in radians, hopefully this prevents others from the same problem.
Also cleaned up some messy whitespace.