Fix no end-of-line bug

[inkarkat]

This fixes #294 by passing the target file through sed (when adding or moving, both of which use simple >> shell redirection which is susceptible to this) to add a trailing newline (EOL) character if one is missing.

Before submitting a pull request, please make sure the following is done:

• Fork the repository and create your branch from master.
• If you've added code that should be tested, add tests!
• Ensure the test suite passes.
• Format your code with ShellCheck.
• Include a human-readable description of what the pull request is trying to accomplish.
• Steps for the reviewer(s) on how they can manually QA the changes.
• Have a fixes #XX reference to the issue that this pull request fixes.

[inkarkat]

@karbassi Somehow, the CI build isn't triggered on this: This branch has not been deployed; I was able to restart an old PR build in Travis, so that still works; maybe the GitHub trigger didn't work. I don't have admin rights to check this.

It's gotten a bit silent here; I've answered a few issues and PRs in the past, but other than that, not much has happened. If you could briefly review my two other open PRs (#271 and #273), I would merge them all in soon. I hope you're fine!

[karbassi]

@inkarkat we might want to move over to Github Actions at some point.

I ran the tests and it failed.

cd tests && ./t1850-move.sh 
* FAIL 1: basic move with implicit source 1
todo.sh -f move 1 done.txt | sed "s#'[^']\+/\([^/']\+\)'#'\1'#g" 
--- expect	2020-03-27 18:37:30.000000000 +0000
+++ output	2020-03-27 18:37:30.000000000 +0000
@@ -1,2 +1,2 @@
 1 (B) smell the uppercase Roses +flowers @outside
-TODO: 1 moved from 'todo.txt' to 'done.txt'.
+TODO: 1 moved from 'tests/trash directory.t1850-move/todo.txt' to 'tests/trash directory.t1850-move/done.txt'.
*   ok 2: basic move with implicit source 2
*   ok 3: basic move with implicit source 3
* FAIL 4: basic move with passed source 1
todo.sh -f move 2 todo.txt done.txt | sed "s#'[^']\+/\([^/']\+\)'#'\1'#g" 
--- expect	2020-03-27 18:37:30.000000000 +0000
+++ output	2020-03-27 18:37:30.000000000 +0000
@@ -1,2 +1,2 @@
 2 x 2009-02-13 smell the coffee +wakeup
-TODO: 2 moved from 'done.txt' to 'todo.txt'.
+TODO: 2 moved from 'tests/trash directory.t1850-move/done.txt' to 'tests/trash directory.t1850-move/todo.txt'.
*   ok 5: basic move with passed source 2
*   ok 6: basic move with passed source 3
* FAIL 7: move to destination without EOL 1
todo.sh -f move 2 todo.txt done.txt | sed "s#'[^']\+/\([^/']\+\)'#'\1'#g" 
--- expect	2020-03-27 18:37:30.000000000 +0000
+++ output	2020-03-27 18:37:30.000000000 +0000
@@ -1,2 +1,2 @@
 2 x 2009-02-13 smell the coffee +wakeup
-TODO: 2 moved from 'done.txt' to 'todo.txt'.
+TODO: 2 moved from 'tests/trash directory.t1850-move/done.txt' to 'tests/trash directory.t1850-move/todo.txt'.
*   ok 8: move to destination without EOL 2
*   ok 9: move to destination without EOL 3
* failed 3 among 9 test(s)
make: *** [tests/t1850-move.sh] Error 1

[karbassi]

We have GitHub Actions now! 👍
The tests are failing. 👎

[karbassi]

t1850-move fails on macOS

[inkarkat]

@karbassi Thank you for setting up the new CI builds; that's really great! (And I involuntarily demonstrated why it's so important to have them.)

I've fixed the compatibility problem; fortunately, that was an easy one and I didn't have to update my FreeBSD VM to see how barren it is in non-GNU land :-)

[karbassi]

@inkarkat looks good. Merge.