Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal config file / default filenames (todo.txt, done.txt, report.txt) #289

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Minimal config file / default filenames (todo.txt, done.txt, report.txt) #289

merged 2 commits into from
Mar 29, 2020

Conversation

eightyfive
Copy link
Contributor

@eightyfive eightyfive commented Jan 10, 2020

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.

Feel free to ignore if this has already been discussed (and please close & point to discussion if so).

It allows to simply create a minimal config file like so:

export TODO_DIR=.

Without explicitly specifying the widely accepted default file names: $TODO_DIR/todo.txt, etc...

Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of defaulting those filespecs directly in the main script, instead of requiring their initialization in the config file. Most users probably stick with the default names, and with this change, those three lines could be dropped (or at least commented out) from the config template.

@karbassi
Copy link
Member

Love it. ❤️

Thanks @eightyfive for the PR and @inkarkat for the review.

@karbassi karbassi merged commit 3d308a6 into todotxt:master Mar 29, 2020
wwalker pushed a commit to wwalker/todo.txt-cli that referenced this pull request Sep 19, 2021
…xt) (todotxt#289)

* Set default files name

* Add test for minimal config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants