Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: todotxt/todo.txt-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: todotxt/todo.txt-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cygwin
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Feb 15, 2012

  1. Get rid of cleanup, only use TMP_FILE in listall. 

    After the recent refactorings, the temporary file is only needed for the listall action. Therefore, the creation-checks and eventual cleanup can be restricted to the listall action, which should slightly speed up the overall script execution.
    @inkarkat @ginatrapani
    inkarkat authored and ginatrapani committed Feb 15, 2012
    Configuration menu
    Copy the full SHA
    c8da8a6 View commit details
    Browse the repository at this point in the history

  2. Break up _list(), get rid of TMP_FILE. 

    Extract a new function _format() (and getPadding(), both also exported for add-ons) from _list(), which includes the main formatting and filtering pipeline, without the file handling and verbose summary. This can receive the todo file via stdin, so the listall action is able to format the concatenated files without going through a temporary file.

Eventually, after further refactorings, _format() could be used for actual formatted verbose messages in all commands; currently, the raw, unformatted task is printed.
    @inkarkat @ginatrapani
    inkarkat authored and ginatrapani committed Feb 15, 2012
    Configuration menu
    Copy the full SHA
    2a0bd60 View commit details
    Browse the repository at this point in the history

  3. Also get rid of TMP_FILE in todo.cfg. 

    There's a slight chance that some add-on has used this (undocumented, unofficial) configuration value for its own purposes (and maybe also relied on the unexposed cleanup() infrastructure), but detecting and fixing that problem (by moving the cleanup into the add-on itself) is pretty straightforward.
    @inkarkat @ginatrapani
    inkarkat authored and ginatrapani committed Feb 15, 2012
    Configuration menu
    Copy the full SHA
    78dab71 View commit details
    Browse the repository at this point in the history

  4. ENH: Allow listpri filtering with priority ranges. 

    So far, the listpri action only supports a single priority. Allowing priority ranges (e.g. todo.sh listpri A-C @work) is a simple but useful enhancement.

Note: The syntax extension only clashes with the [TERM] filtering in a few corner cases, and this can be worked around (e.g. "todo.sh listpri A-Z A-Z" lists all prioritized tasks containing the text A-Z).
    @inkarkat @ginatrapani
    inkarkat authored and ginatrapani committed Feb 15, 2012
    Configuration menu
    Copy the full SHA
    16b1cb5 View commit details
    Browse the repository at this point in the history
Loading