From c6d70aba1a9e04849dbd73eefdb55ca92780950c Mon Sep 17 00:00:00 2001 From: Aashish Rajaram Salokhe <40220544+aashish1987@users.noreply.github.com> Date: Tue, 6 Jul 2021 20:24:30 -0700 Subject: [PATCH] BugFix: Set readonly flag to false for non-read only properties in Guest Configuration (#14999) * Bug-Fix: Remove read-only properties from Guest Configuration objects * Resolved PR comments. Updated examples * Add Assignment Type * Fix Prettier check Co-authored-by: Aashish Rajaram Salokhe --- ...eateOrUpdateGuestConfigurationAssignment.json | 3 +++ ...OrUpdateGuestConfigurationHCRPAssignment.json | 3 +++ .../stable/2018-11-20/guestconfiguration.json | 16 ++++++++++++++-- ...eateOrUpdateGuestConfigurationAssignment.json | 3 +++ ...OrUpdateGuestConfigurationHCRPAssignment.json | 3 +++ .../stable/2020-06-25/guestconfiguration.json | 16 ++++++++++++++-- ...eateOrUpdateGuestConfigurationAssignment.json | 3 +++ ...OrUpdateGuestConfigurationHCRPAssignment.json | 3 +++ .../stable/2021-01-25/guestconfiguration.json | 16 ++++++++++++++-- 9 files changed, 60 insertions(+), 6 deletions(-) diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationAssignment.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationAssignment.json index 13e8b863c2d9..c2b259c8097a 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationAssignment.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationAssignment.json @@ -13,6 +13,9 @@ "guestConfiguration": { "name": "WhitelistedApplication", "version": "1.*", + "contentUri": "https://thisisfake/pacakge", + "contentHash": "123contenthash", + "assignmentType": "ApplyAndAutoCorrect", "configurationParameter": [ { "name": "[InstalledApplication]bwhitelistedapp;Name", diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationHCRPAssignment.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationHCRPAssignment.json index 1e767f4eb152..c1e83dbde488 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationHCRPAssignment.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/examples/createOrUpdateGuestConfigurationHCRPAssignment.json @@ -13,6 +13,9 @@ "guestConfiguration": { "name": "WhitelistedApplication", "version": "1.*", + "contentUri": "https://thisisfake/pacakge", + "contentHash": "123contenthash", + "assignmentType": "ApplyAndAutoCorrect", "configurationParameter": [ { "name": "[InstalledApplication]bwhitelistedapp;Name", diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json index 239870a2cec5..2374f0f1f542 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json @@ -803,15 +803,27 @@ "description": "Version of the guest configuration." }, "contentUri": { - "readOnly": true, "type": "string", "description": "Uri of the storage where guest configuration package is uploaded." }, "contentHash": { - "readOnly": true, "type": "string", "description": "Combined hash of the guest configuration package and configuration parameters." }, + "assignmentType": { + "type": "string", + "description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.", + "x-ms-enum": { + "name": "assignmentType", + "modelAsString": true + }, + "enum": [ + "Audit", + "DeployAndAutoCorrect", + "ApplyAndAutoCorrect", + "ApplyAndMonitor" + ] + }, "configurationParameter": { "type": "array", "items": { diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationAssignment.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationAssignment.json index 44db64b95018..f73a5be12239 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationAssignment.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationAssignment.json @@ -13,6 +13,9 @@ "guestConfiguration": { "name": "WhitelistedApplication", "version": "1.*", + "contentUri": "https://thisisfake/pacakge", + "contentHash": "123contenthash", + "assignmentType": "ApplyAndAutoCorrect", "configurationParameter": [ { "name": "[InstalledApplication]bwhitelistedapp;Name", diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json index 330a83431816..81f468079d03 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json @@ -13,6 +13,9 @@ "guestConfiguration": { "name": "WhitelistedApplication", "version": "1.*", + "contentUri": "https://thisisfake/pacakge", + "contentHash": "123contenthash", + "assignmentType": "ApplyAndAutoCorrect", "configurationParameter": [ { "name": "[InstalledApplication]bwhitelistedapp;Name", diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json index 7f896d2ac18a..7164a0b561fc 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json @@ -803,15 +803,27 @@ "description": "Version of the guest configuration." }, "contentUri": { - "readOnly": true, "type": "string", "description": "Uri of the storage where guest configuration package is uploaded." }, "contentHash": { - "readOnly": true, "type": "string", "description": "Combined hash of the guest configuration package and configuration parameters." }, + "assignmentType": { + "type": "string", + "description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.", + "x-ms-enum": { + "name": "assignmentType", + "modelAsString": true + }, + "enum": [ + "Audit", + "DeployAndAutoCorrect", + "ApplyAndAutoCorrect", + "ApplyAndMonitor" + ] + }, "configurationParameter": { "type": "array", "items": { diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationAssignment.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationAssignment.json index 473c44588a2b..d67520d7478d 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationAssignment.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationAssignment.json @@ -13,6 +13,9 @@ "guestConfiguration": { "name": "WhitelistedApplication", "version": "1.*", + "contentUri": "https://thisisfake/pacakge", + "contentHash": "123contenthash", + "assignmentType": "ApplyAndAutoCorrect", "configurationParameter": [ { "name": "[InstalledApplication]bwhitelistedapp;Name", diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json index 74fd35a92a7f..a2f7f3a4d03c 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/examples/createOrUpdateGuestConfigurationHCRPAssignment.json @@ -13,6 +13,9 @@ "guestConfiguration": { "name": "WhitelistedApplication", "version": "1.*", + "contentUri": "https://thisisfake/pacakge", + "contentHash": "123contenthash", + "assignmentType": "ApplyAndAutoCorrect", "configurationParameter": [ { "name": "[InstalledApplication]bwhitelistedapp;Name", diff --git a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json index fac640dcaa9b..ec65d21e12ba 100644 --- a/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json +++ b/specification/guestconfiguration/resource-manager/Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json @@ -1088,15 +1088,27 @@ "description": "Version of the guest configuration." }, "contentUri": { - "readOnly": true, "type": "string", "description": "Uri of the storage where guest configuration package is uploaded." }, "contentHash": { - "readOnly": true, "type": "string", "description": "Combined hash of the guest configuration package and configuration parameters." }, + "assignmentType": { + "type": "string", + "description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.", + "x-ms-enum": { + "name": "assignmentType", + "modelAsString": true + }, + "enum": [ + "Audit", + "DeployAndAutoCorrect", + "ApplyAndAutoCorrect", + "ApplyAndMonitor" + ] + }, "configurationParameter": { "type": "array", "items": {