Ambient Light API #465
Merged
Ambient Light API #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvanwhy
reviewed
May 1, 2023
|
I tested this on Imix (using #466) and it appears to work correctly! |
|
Using |
alexandruradovici
requested changes
May 2, 2023
alexandruradovici
requested changes
May 2, 2023
jrvanwhy
added
the
upkeep
alexandruradovici
approved these changes
May 4, 2023
alexandruradovici
requested changes
May 5, 2023
apis/ambient_light/src/lib.rs
Outdated
|
|
||
| /// Register an events listener | ||
| pub fn register_listener<'share>( | ||
| listener: &'share Cell<Option<(u32,)>>, |
There was a problem hiding this comment.
I think we did this wrong here. We need to be able to register a listener that the user can actually use outside this crate, meaning that the listener needs to have a function that is called when the upcall is fired.
Something similar to the ButtonListener should work.
alexandruradovici
approved these changes
May 9, 2023
alexandruradovici
approved these changes
May 12, 2023
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR adds an Ambient Light API, which includes:
Alongside the API, this PR adds a fake driver (and unit tests for it) for testing the API.
Testing Strategy
This pull request was tested using unit tests made specifically for this API and fake driver.
TODO or Help Wanted
This pull request still needs feedback / code review.
Help is needed to test this on a board, as I do not have access to one which has a light sensor module
@hudson-ayers could you, please, test it on a imix