Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Organize and label MPU unit tests #498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ppannuto
Copy link
Member

We have lots of MPU tests, and it's not necessarily obvious why.

This aims to give a "memory map" to the array of tests, as well as to make more obvious where you might start for any interactive testing.

@bradjc
Copy link
Contributor

bradjc commented Mar 20, 2025

Why do we need another sub folder?

@ppannuto
Copy link
Member Author

We don't need a subfolder, but I'll quote myself from the README updates for the rationale:

MPU test applications are necessarily somewhat fine-grained, as each MPU
violation results in termination of the test process.

As it can be annoying to flash myriad apps during development, the tests in the
top-level directory attempt to exercise all of the reads and writes of regions
that should work during normal operation (and allow use of a button to inject
faults for interactive testing). The unit/ folder holds all of the smaller
tests which attempt to violate access rules at each of the boundaries.

@bradjc
Copy link
Contributor

bradjc commented Mar 26, 2025

But we don't have any other tests. Let's just add the folder when we know we need it. We have many groups of tests, many of which can be annoying to run. I don't think there is anything different about MPU.

@ppannuto
Copy link
Member Author

Yes we do?

mpu_walk_region is still in the root folder here, and #497 adds a second root-level test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants