Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes: add revision-vs-revision comparison option #240

Open
quasilyte opened this issue Mar 1, 2018 · 4 comments
Open

changes: add revision-vs-revision comparison option #240

quasilyte opened this issue Mar 1, 2018 · 4 comments
Labels

Comments

@quasilyte
Copy link
Contributor

quasilyte commented Mar 1, 2018

This is a feature request.

Description.

New view option for "Changes" page.
In addition to "show n last" revisions, it makes possible to select two revisions by their commit hash.
It's not obvious what to do with "trend" column, but "changes" column will show difference between two revisions (better/worse).

==

The required functionality is "revision vs revision" comparison (same executable, same environment, ...).
If codespeed already has one, which escaped my attention, this feature request can be closed.

@quasilyte
Copy link
Contributor Author

quasilyte commented Mar 1, 2018

The closest solution I found is to create two new executables, each of them includes results of the interest. Then "Comparison" page can be used to compare them.
It could require only one temporary executable if there was an option to select the revision.

But for some reason, this leads to empty comparison plot (no bars, see image below).

image

The big picture: I want to compare some older version with newer (say, year later release) and use benchmarks with geomean to compare them. I'm OK with any representation: be it +/- change like in "Changes" or bar plot like in "Comparison".

@quasilyte
Copy link
Contributor Author

quasilyte commented Mar 5, 2018

The empty plots are a consequence of the absence of lastest commit in those executable results.
Not sure if this is an expected behavior (from functional point of view).

By changing results revision to the default branch tip, plots are no longer empty:
image

@tobami tobami added the FEATURE label Mar 10, 2018
@tobami
Copy link
Owner

tobami commented Mar 10, 2018

So is the feature request to make it possible to compare any two commit hashes?

@quasilyte
Copy link
Contributor Author

quasilyte commented Mar 10, 2018

Yes.
I will come back with reasons why this is useful.

IIRC it's useful when you know exact hashes when feature A was enabled and when it was disabled. You want to compare those to measure the effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants