Django: Use path funcion instead of url funcion#129
Open
r-lelis wants to merge 4 commits intotoastdriven:masterfrom
Open
Django: Use path funcion instead of url funcion#129r-lelis wants to merge 4 commits intotoastdriven:masterfrom
r-lelis wants to merge 4 commits intotoastdriven:masterfrom
Conversation
r-lelis
changed the title
r-lelis
force-pushed
the
replace-url-function
branch
from
90d12c2 to
08c5102
Compare
r-lelis
force-pushed
the
replace-url-function
branch
from
08c5102 to
8572b24
Compare
r-lelis
force-pushed
the
replace-url-function
branch
from
4ebd9b8 to
a2e5b0c
Compare
cawal
approved these changes
Dec 29, 2021
Contributor
Author
|
I'm having some problems triggering Travis's tests |
|
This is a really good thing to have for those whom use Django 4. Is there any I can do? |
zshanhui
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
django.conf.urls.urlfunction has been deprecated since version 3.1 and wil be removed on version 4. I replaced it with the easier to readpathfunction.Edit: I also added the support for Django 4.0 on tox and on Travis. I think this PR is important to make sure that people can update to later versions of Django without break anything.