Skip to content

Commit 4796e05

Browse files
authored
test_runner,doc: align documentation with actual stdout/stderr behavior
PR-URL: nodejs#53131 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent a2446de commit 4796e05

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

doc/api/test.md

-8
Original file line numberDiff line numberDiff line change
@@ -2864,11 +2864,7 @@ The corresponding execution ordered event is `'test:dequeue'`.
28642864
### Event: `'test:stderr'`
28652865

28662866
* `data` {Object}
2867-
* `column` {number|undefined} The column number where the test is defined, or
2868-
`undefined` if the test was run through the REPL.
28692867
* `file` {string} The path of the test file.
2870-
* `line` {number|undefined} The line number where the test is defined, or
2871-
`undefined` if the test was run through the REPL.
28722868
* `message` {string} The message written to `stderr`.
28732869

28742870
Emitted when a running test writes to `stderr`.
@@ -2879,11 +2875,7 @@ defined.
28792875
### Event: `'test:stdout'`
28802876

28812877
* `data` {Object}
2882-
* `column` {number|undefined} The column number where the test is defined, or
2883-
`undefined` if the test was run through the REPL.
28842878
* `file` {string} The path of the test file.
2885-
* `line` {number|undefined} The line number where the test is defined, or
2886-
`undefined` if the test was run through the REPL.
28872879
* `message` {string} The message written to `stdout`.
28882880

28892881
Emitted when a running test writes to `stdout`.

lib/internal/test_runner/tests_stream.js

-8
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,6 @@ class TestsStream extends Readable {
123123
});
124124
}
125125

126-
stderr(loc, message) {
127-
this[kEmitMessage]('test:stderr', { __proto__: null, message, ...loc });
128-
}
129-
130-
stdout(loc, message) {
131-
this[kEmitMessage]('test:stdout', { __proto__: null, message, ...loc });
132-
}
133-
134126
coverage(nesting, loc, summary) {
135127
this[kEmitMessage]('test:coverage', {
136128
__proto__: null,

0 commit comments

Comments
 (0)