PHPStan yourself

Author: andytson-inviqa

composer.json

@@ -5,10 +5,18 @@
     "require": {
         "phpstan/phpstan": "0.11.*"
     },
-	"autoload": {
-		"psr-4": {
-			"PHPStanMagento1\\": "src/"
-		}
-	},
+    "autoload": {
+        "psr-4": {
+            "PHPStanMagento1\\": "src/"
+        }
+    },
+    "scripts": {
+        "test-quality": [
+            "phpstan analyse"
+        ],
+        "test": [
+            "@test-quality"
+        ]
+    },
     "license": "MIT"
 }

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+    paths:
+        - src
+    level: 7

src/Autoload/Magento/ModuleControllerAutoloader.php

@@ -4,11 +4,7 @@
 
 use Mage;
 use ReflectionClass;
-
-function includeFile(string $file)
-{
-    include $file;
-}
+use Exception;
 
 class ModuleControllerAutoLoader
 {
@@ -23,7 +19,11 @@ public function __construct($codePool, $magentoRoot = null)
     {
         if (empty($magentRoot)) {
             $mageClass = new ReflectionClass(Mage::class);
-            $magentoRoot = dirname($mageClass->getFileName(), 2);
+            if ($mageClass->getFileName() !== false) {
+                $magentoRoot = dirname($mageClass->getFileName(), 2);
+            } else {
+                throw new Exception('Could not find path to Mage class');
+            }
         }
         $this->codePool = $codePool;
         $this->magentoRoot = $magentoRoot;
@@ -39,7 +39,9 @@ public function autoload($className)
         if (preg_match('/^([a-zA-Z0-9\x7f-\xff]*)_([a-zA-Z0-9\x7f-\xff]*)_([a-zA-Z0-9_\x7f-\xff]+)/', $className, $match) === 1) {
             $controllerFilename = sprintf('%s/app/code/%s/%s/%s/controllers/%s.php', $this->magentoRoot, $this->codePool, $match[1], $match[2], $match[3]);
             if (file_exists($controllerFilename)) {
-                includeFile($controllerFilename);
+                (function ($file) {
+                    include $file;
+                })($controllerFilename);
             }
         }
     }

src/Reflection/Varien/Object/MagicMethodReflection.php

@@ -9,6 +9,11 @@
 
 class MagicMethodReflection implements MethodReflection
 {
+    /**
+     * @var string
+     */
+    private $name;
+
     /**
      * @var ClassReflection
      */

src/Type/Mage/Core/Model/Layout/HelperMethodsReturnTypeExtension.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace PHPStanMagento1\Type\Mage;
+namespace PHPStanMagento1\Type\Mage\Core\Model\Layout;
 
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Scalar\String_;
@@ -11,6 +11,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 
+use Mage;
 use Mage_Core_Model_Layout;