Improve PPX template #124
Open
Improve PPX template #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I try to improve the PPX template a bit: - The rewriter in `bin/main.exe` can now be used on source files directly. - The `CONTRIBUTING.md` documents this feature.
tmattio
reviewed
Dec 15, 2021
| @@ -0,0 +1,3 @@ | |||
| open Ppxlib | |||
There was a problem hiding this comment.
Shouldn't this file be .ml and not .mli? Also should we add a dune file with a test stanza for it?
There was a problem hiding this comment.
You're right.
There is a story to this. The original template had no test/{{ project_snake }}_test.mli and make test was complaining that the mli file is missing. I was confused and tried to copy the empty bin/main.mli to test/{{ project_snake }}_test.mli. Missed an i obviously. But how can it first ask for an mli and then accept an invalid mli?
I'll try again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to improve the PPX template a bit:
bin/main.execan now be used on source files directly.CONTRIBUTING.mddocuments this feature.