Skip to content

build: Lock + document Cargo.lock #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

build: Lock + document Cargo.lock #885

wants to merge 5 commits into from

Conversation

heeckhau
Copy link
Member

@heeckhau heeckhau linked an issue May 23, 2025 that may be closed by this pull request
Clean up Cargo.lock handling in repo and CI #884
Open
@heeckhau heeckhau requested review from themighty1 and sinui0 May 27, 2025 07:40
themighty1
themighty1 approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need to update the doc to
git update-index --skip-worktree Cargo.lock
for those who dont want to see Cargo.toml in git diff

heeckhau
heeckhau commented May 27, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themighty1 themighty1 themighty1 approved these changes

@sinui0 sinui0 Awaiting requested review from sinui0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up Cargo.lock handling in repo and CI
2 participants
@heeckhau @themighty1