feat: Aliasing a npm module without 'npm:' (#73)

tleunen · Aug 19, 2016 · 8e95988 · 8e95988
1 parent 3d4756b
commit 8e95988
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,8 @@ Specify the plugin in your `.babelrc` with the custom root or alias. Here's an e
       ["module-resolver", {
         "root": ["./src"],
         "alias": {
-          "test": "./test"
+          "test": "./test",
+          "underscore": "lodash"
         }
       }]
     ]

diff --git a/src/index.js b/src/index.js
@@ -57,7 +57,15 @@ export function mapModule(source, file, pluginOpts) {
         return null;
     }
 
+    // remove legacy "npm:" prefix for npm packages
+    aliasPath = aliasPath.replace(/^(npm:)/, '');
     const newPath = source.replace(moduleSplit.join('/'), aliasPath);
+
+    // alias to npm module don't need relative mapping
+    if (aliasPath[0] !== '.') {
+        return newPath;
+    }
+    // relative alias
     return mapToRelative(file, newPath);
 }
 

diff --git a/src/mapToRelative.js b/src/mapToRelative.js
@@ -20,12 +20,6 @@ export default function mapToRelative(currentFile, module) {
 
     moduleMapped = toPosixPath(moduleMapped);
 
-    // Support npm modules instead of directories
-    if (moduleMapped.indexOf('npm:') !== -1) {
-        const [, npmModuleName] = moduleMapped.split('npm:');
-        return npmModuleName;
-    }
-
     if (moduleMapped[0] !== '.') moduleMapped = `./${moduleMapped}`;
 
     return moduleMapped;

diff --git a/test/index.js b/test/index.js
@@ -68,7 +68,8 @@ describe('alias', () => {
                 alias: {
                     utils: './src/mylib/subfolder/utils',
                     'awesome/components': './src/components',
-                    abstract: 'npm:concrete'
+                    abstract: 'npm:concrete',
+                    underscore: 'lodash'
                 }
             }]
         ]
@@ -138,11 +139,19 @@ describe('alias', () => {
         });
     });
 
-    describe('should support remapping to node modules with "npm:"', () => {
+    describe('(legacy) should support aliasing a node module with "npm:"', () => {
         testRequireImport(
             'abstract/thing',
             'concrete/thing',
             transformerOpts
         );
     });
+
+    describe('should support aliasing a node modules', () => {
+        testRequireImport(
+            'underscore/map',
+            'lodash/map',
+            transformerOpts
+        );
+    });
 });