Skip to content

pake: add page #9822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 4, 2023
Merged

pake: add page #9822

merged 12 commits into from
Feb 4, 2023

Conversation

fnfontana
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Feb 2, 2023
@fnfontana
Copy link
Contributor Author

fnfontana commented Feb 2, 2023 •
edited
Loading

Hello, I've added a new tldr page for Pake.

Note: I have read all the contributing guide and tried to follow the rules, but I'm still learning Git/GitHub, so if I've done something wrong, just let me know that I will fix it.

@fnfontana
pake: edit examples
561910c 
Add a concrete example instead of a generic one.
@fnfontana
pake: remove unnecessary text
82a6d18 
Removed the "[options]" generic flag to conform with tldr-pages standards, offering concrete examples instead.
blueskyson
blueskyson reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@blueskyson blueskyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. Just left some syntax suggestions.

fnfontana and others added 6 commits February 3, 2023 10:12
@fnfontana @blueskyson
pake: accept suggestion
7b82827 
Co-authored-by: Jack Lin <blueskyson1401@gmail.com>
@fnfontana @blueskyson
pake: accept suggestion
930cf1a 
Co-authored-by: Jack Lin <blueskyson1401@gmail.com>
@fnfontana @blueskyson
pake: accept suggestion
7c7bd6f 
Co-authored-by: Jack Lin <blueskyson1401@gmail.com>
@fnfontana @blueskyson
pake: accept suggestion
d9ddb80 
Co-authored-by: Jack Lin <blueskyson1401@gmail.com>
@fnfontana @blueskyson
pake: accept suggestion
58d0d51 
Co-authored-by: Jack Lin <blueskyson1401@gmail.com>
@fnfontana @blueskyson
pake: accept suggestion
137b5f8 
Co-authored-by: Jack Lin <blueskyson1401@gmail.com>
@fnfontana
Copy link
Contributor Author

Thanks for contribution. Just left some syntax suggestions.

All suggestions committed.

kbdharun
kbdharun reviewed Feb 3, 2023
View reviewed changes
kbdharun
kbdharun approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some minor suggestions for this page.

fnfontana and others added 3 commits February 3, 2023 15:41
@fnfontana @kbdharun
pake: accept suggestion
af90d10 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@fnfontana @kbdharun
pake: accept suggestion
be486a2 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@fnfontana @kbdharun
pake: accept suggestion
ed8a3d4 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@fnfontana
Copy link
Contributor Author

fnfontana commented Feb 3, 2023 •
edited
Loading

Thanks for your contribution. I have some minor suggestions for this page.

Suggestions committed.

@kbdharun kbdharun requested a review from navarroaxel February 4, 2023 04:50
@Waples Waples merged commit d983fd1 into tldr-pages:main Feb 4, 2023
@kbdharun kbdharun removed the request for review from navarroaxel February 5, 2023 02:39
@fnfontana fnfontana deleted the new-page/pake branch February 5, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@blueskyson blueskyson blueskyson approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fnfontana @kbdharun @blueskyson @Waples