Skip to content

nu: fix log-level command instructions #9812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

nu: fix log-level command instructions #9812

merged 1 commit into from
Feb 1, 2023

Conversation

jordan-chalupka
Copy link
Contributor

@jordan-chalupka jordan-chalupka commented Jan 28, 2023 •
edited
Loading

This flag should be called log-level

> nu --loglevel info
× The `nu` command doesn't have flag `loglevel`.
   ╭─[source:1:1]
 1 │ nu --loglevel
   ·    ─────┬────
   ·         ╰── unknown flag

After:

> nu --log-level info
2023-01-28 07:57:42.536 PM [INFO ] nu: start logging src/main.rs:288:67
  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@jordan-chalupka
nu: fix log-level command instructions
1790357 
This flag should be called `log-level`
```
> nu --loglevel info
× The `nu` command doesn't have flag `loglevel`.
   ╭─[source:1:1]
 1 │ nu --loglevel
   ·    ─────┬────
   ·         ╰── unknown flag
```
After:
```
> nu --log-level info
2023-01-28 07:57:42.536 PM [INFO ] nu: start logging src/main.rs:288:67
```
@CLAassistant
Copy link

CLAassistant commented Jan 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jan 28, 2023
kbdharun
kbdharun approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun added the minor change Change(s) to an existing page(s) which is minor. label Jan 29, 2023
owenvoke
owenvoke approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just double checked this).

@owenvoke owenvoke merged commit d47aa90 into tldr-pages:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

@kbdharun kbdharun kbdharun approved these changes

@blueskyson blueskyson blueskyson approved these changes

Assignees
No one assigned
Labels
minor change Change(s) to an existing page(s) which is minor. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jordan-chalupka @CLAassistant @owenvoke @kbdharun @blueskyson