-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
*: fix errors reported by languagetool #6069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is some really superb work — the most ultimate height of typo-fixing that I could have ever imagined 🚀🚀🚀
Here are my opinions regarding your ignored changes (in a nutshell, don't ignore any of them!):
I think we should definitely uppercase these.
Uppercase these too.
This has tricked me alot, I think we should use "all the"
Definitely.
Yep, too wordy is beating around the bush. |
@SethFalco maybe also normalize |
I'll stop with the commit spam now. I've applied most of the feedback, and some of the things that I remember skipping before. |
Now why'd you call your branch |
Because going through all the problems LanguageTool reported was much more boring than I expected, I wanted to give a subtle clue to my cause of death in case "dying from boredom" could really happen. |
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Thanks for the heads-up, should be good to go! |
Nice, I'll merge |
Inspired by: #5848
This only does the English files, LanguageTool does support other languages, but I can't manually review the suggestions.
I dumped only lines starting with
>
or-
from the English files into a single file to save time.The following is a non-exhaustive list of the changes made to the repository.
Notable Changes
Hyphenated Words or Redundant Spaces
Fixed Nouns
Fixed Acronyms
Typos
Misc Errors
Redundancies
These technically aren't incorrect, just longer than it needs to be.
Ignored
The following I ignored on purpose, feel free to drop opinions on them.
British vs American English
I also ignored locale-specific reports like British vs American English as discussed on Matrix. (More Info)
False Positives
It's common to refer to things like npm in lowercase even though it's technically an acronym. This makes LanguageTool mad since it thinks it's an actual word. ie
a npm package
vsan npm package
. It thinks "a npm package" is correct, but because we mean "a NPM package" it should be "an npm package".I decided to be terrible and fixed another thing on the side in this PR.
There was a command that had extra spaces between arguments, so I also removed that. Nothing to do with LanguageTool.