Skip to content

sgpt: add page #10095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2023
Merged

sgpt: add page #10095

merged 3 commits into from
Apr 22, 2023

Conversation

sufyandaredevil
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Apr 20, 2023
kbdharun
kbdharun reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and welcome to tldr. I have some suggestions for this page.

@kbdharun
Copy link
Member

Tip: You can batch all suggestions and make a single commit from the "Files tab" in the web interface.

@sufyandaredevil
Copy link
Contributor Author

Tip: You can batch all suggestions and make a single commit from the "Files tab" in the web interface.

Sure I'll do it

sufyandaredevil
sufyandaredevil commented Apr 20, 2023
View reviewed changes
Copy link
Contributor Author

@sufyandaredevil sufyandaredevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgpt: fix typos

@sufyandaredevil @kbdharun
Apply suggestions from code review
c756de0 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
sufyandaredevil
sufyandaredevil commented Apr 20, 2023
View reviewed changes
Copy link
Contributor Author

@sufyandaredevil sufyandaredevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes mentioned are all batch committed

@sufyandaredevil
Copy link
Contributor Author

@kbdharun can you review it again, I've batched and committed all changes you mentioned

kbdharun
kbdharun approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@sufyandaredevil @kbdharun
Apply suggestions from code review
8f302c3 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
sufyandaredevil
sufyandaredevil commented Apr 20, 2023
View reviewed changes
Copy link
Contributor Author

@sufyandaredevil sufyandaredevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgpt: fixed alphabet case

@pixelcmtd pixelcmtd merged commit fd267f0 into tldr-pages:main Apr 22, 2023
@sufyandaredevil sufyandaredevil deleted the sgpt branch April 22, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@pixelcmtd pixelcmtd pixelcmtd approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sufyandaredevil @kbdharun @pixelcmtd