Skip to content

genisoimage: add page and Brazilian Portuguese Translation #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 23, 2023
Merged

genisoimage: add page and Brazilian Portuguese Translation #10068

merged 15 commits into from
Apr 23, 2023

Conversation

vitormarcal
Copy link
Contributor

@vitormarcal vitormarcal commented Apr 12, 2023 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. translation Issues requesting translating pages from English to other languages. labels Apr 12, 2023
Magrid0
Magrid0 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

kbdharun
kbdharun reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

@kbdharun kbdharun requested a review from waldyrious April 21, 2023 07:03
vitormarcal and others added 6 commits April 21, 2023 08:24
@vitormarcal @kbdharun
Update pages.pt_BR/linux/genisoimage.md
ef7baf3 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@vitormarcal @kbdharun
Update pages.pt_BR/linux/genisoimage.md
a72fa8e 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@vitormarcal @kbdharun
Update pages.pt_BR/linux/genisoimage.md
f6a01d8 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@vitormarcal @kbdharun
Update pages/linux/genisoimage.md
108e624 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@vitormarcal @kbdharun
Update pages/linux/genisoimage.md
8fbb1d4 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@vitormarcal @kbdharun
Update pages/linux/genisoimage.md
9fc6f77 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@vitormarcal vitormarcal requested a review from kbdharun April 21, 2023 11:26
waldyrious
waldyrious reviewed Apr 21, 2023
View reviewed changes
@vitormarcal @waldyrious
Update pages.pt_BR/linux/genisoimage.md
9a94556 
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
waldyrious
waldyrious reviewed Apr 21, 2023
View reviewed changes
@vitormarcal vitormarcal requested a review from waldyrious April 21, 2023 11:29
waldyrious
waldyrious reviewed Apr 21, 2023
View reviewed changes
@waldyrious
Copy link
Member

Thanks for contributing to tldr-pages, @vitormarcal, and especially for expanding the Portuguese content coverage :) Welcome aboard!

@vitormarcal vitormarcal requested a review from waldyrious April 21, 2023 12:06
@vitormarcal vitormarcal requested a review from Magrid0 April 22, 2023 13:27
waldyrious
waldyrious reviewed Apr 22, 2023
View reviewed changes
waldyrious
waldyrious reviewed Apr 22, 2023
View reviewed changes
@vitormarcal @waldyrious
Apply suggestions from code review
7f7e8e2 
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
@vitormarcal vitormarcal requested a review from waldyrious April 22, 2023 17:20
waldyrious
waldyrious approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks for the contribution!

@waldyrious
Copy link
Member

(Whoever merges this, don't forget to squash the commits.)

kbdharun
kbdharun approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 2c3ac25 into tldr-pages:main Apr 23, 2023
@vitormarcal vitormarcal deleted the add_page_genisoimage branch April 24, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldyrious waldyrious waldyrious approved these changes

@kbdharun kbdharun kbdharun approved these changes

@Magrid0 Magrid0 Awaiting requested review from Magrid0

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitormarcal @waldyrious @kbdharun @Magrid0