fix: Update command does not work with proxy #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbdharun
added
the
hacktoberfest-accepted
MasterOdin
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Hi @code2933, could you please rebase your PR on the latest main?
Working on it. Seems I did a wrong action. I will create a new PR when it's finished. |
|
Hey, I have merged previous commits and reopen this PR. I have to note that I did not realize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed the problem that command
tldr --updatedoes not work with proxy. These unresolved issues originate from the same reason:It's a bug from axios that axios does not support HTTPS over HTTP proxy axios/axios#5037 (a dead PR).
This PR replaces axios with node-fetch with tiny changes.
Checklist
Please review this checklist before submitting a pull request.
npm run test:all)