Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Stop model checking" button doesn't work on Windows #345

Open
hwayne opened this issue Oct 24, 2024 · 2 comments
Open

"Stop model checking" button doesn't work on Windows #345

hwayne opened this issue Oct 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hwayne
Copy link

hwayne commented Oct 24, 2024

Description:

image

I'm running in simulation mode, so TLC should only stop when I click the "stop" link. Clicking it does nothing. This is also true with regular model checking and unbound models.

Steps to reproduce:

  1. Start a spec
  2. Click the "stop" button next to Running

Expectations:

TLC should stop checking. It continues until it finishes (or forever).

Version Information:

  • Plugin Version: v2024.10.192237
  • OS: Windows 11
@hwayne hwayne added the bug Something isn't working label Oct 24, 2024
@FedericoPonzi
Copy link
Collaborator

I'm sorry but I wasn't able to reproduce. I tried on both Windows 11 and Ubuntu, in my laptop when I click on (stop) the state switches from Running to Stopped and I can see the java pid is also gone.

When that button is clicked, internally it calls process.kill('SIGINT'), which causes a graceful termination on Linux while on Windows according to the doc:

On Windows, where POSIX signals do not exist, the signal argument will be ignored, and the process will be killed forcefully and abruptly (similar to'SIGKILL').

I tested in both simulate and normal model checking, and I also tried to wait 3 minutes before stopping and worked every time.

@hwayne
Copy link
Author

hwayne commented Nov 12, 2024

ACKN, I'll see if I can figure out why that's not working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants