Upload error in upload_to_canvas should probably stop processing

[jonespm]

We had a case where the script detected an error where workflow_state = failed. However when an error was printed the job continued on and the files were archived. The process was considered a success.

Upon investigation the workflow_state was imported which is pretty weird. Why did the script notice that it was filed?

I, [2023-04-19T13:11:38.432774 #27]  INFO -- : Canvas upload job id = 13873 processed 0 with workflow_state = failed
E, [2023-04-19T13:11:38.432810 #27] ERROR -- : upload error: Canvas upload job id = 13873 failed

The job probably should return an error here and have us investigate it manually rather than breaking and continuing the process.

canvas/SIS_import/sis_upload.rb

Line 215 in 54005a1

$logger.error "upload error: #{upload_error}"