Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub.jl? #36

Open
tkf opened this issue Jan 25, 2020 · 3 comments
Open

Use GitHub.jl? #36

tkf opened this issue Jan 25, 2020 · 3 comments

Comments

@tkf
Copy link
Owner

tkf commented Jan 25, 2020

... though what's done here ATM is simple enough to do with curl.

@johnnychen94
Copy link
Collaborator

johnnychen94 commented Jan 25, 2020

Github.jl looks like a good option. If it's not on your table, I'll check it when I finished my Julia mirror project https://github.com/johnnychen94/jill.py ; I want to make it announced together with Julia 1.4 release :P

@tkf
Copy link
Owner Author

tkf commented Jan 25, 2020

Sounds good. FYI what I was thinking was to add a proper error handling in

cmd = ```
curl
--include
--request POST
$url
-H "Content-Type: application/json"
-H "Authorization: token $GITHUB_TOKEN"
--data @-
```
response = sprint() do stdout
open(pipeline(cmd, stdout = stdout, stderr = stderr), write = true) do io
printcommentjson(io, ciresult)
end
end
@debug "Response from GitHub" Text(response)

(jill.py looks nice! BTW)

@filchristou
Copy link

GitHub.jl is in the current dependencies. Can we close this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants