fix(platform): update cls/mc needupdate logic #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoryu
force-pushed
the
fix/update_needupdate_logic
branch
4 times, most recently
from
411a7b2 to
a6cd919
Compare
leoryu
changed the title
pavlelee
requested changes
Aug 23, 2021
| c.queue.Add(key) | ||
| } | ||
|
|
||
| func (c *Controller) needsUpdate(old *platformv1.Cluster, new *platformv1.Cluster) bool { |
Collaborator
There was a problem hiding this comment.
machine controller will upgrade too.
Collaborator
There was a problem hiding this comment.
can you add some test case for needsUpdate, ensure that several state judgments meet expectations
| }, | ||
| want: false, | ||
| }, | ||
| // TODO: Add test cases. |
Collaborator
There was a problem hiding this comment.
miss :
- old.ClusterCondition.Status=Unknown && new.ClusterCondition.Status=True
- old.ClusterCondition.Status=Unknown && new.ClusterCondition.Status=False
- old.ClusterCondition.Status=Unknown && new.ClusterCondition.Status=Unknown
- old.ClusterCondition.Status=True && new.ClusterCondition.Status=Unknown
-
- old.ClusterCondition.Status=False && new.ClusterCondition.Status=Unknown
leoryu
force-pushed
the
fix/update_needupdate_logic
branch
from
a6cd919 to
e126f3a
Compare
leoryu
force-pushed
the
fix/update_needupdate_logic
branch
from
e126f3a to
24437c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: