Improve unit tests.

Author: efkon-tkem

tests/test_fifo.py

@@ -5,7 +5,7 @@
 from . import CacheTestMixin
 
 
-class LRUCacheTest(unittest.TestCase, CacheTestMixin):
+class FIFOCacheTest(unittest.TestCase, CacheTestMixin):
     Cache = FIFOCache
 
     def test_fifo(self):
@@ -54,3 +54,15 @@ def test_fifo_getsizeof(self):
             cache[4] = 4
         self.assertEqual(len(cache), 1)
         self.assertEqual(cache[3], 3)
+
+    def test_fifo_update_existing(self):
+        cache = FIFOCache(maxsize=2)
+
+        cache[1] = 1
+        cache[2] = 2
+        cache[1] = "updated"
+        cache[3] = 3
+
+        self.assertEqual(cache[1], "updated")
+        self.assertIn(3, cache)
+        self.assertNotIn(2, cache)

tests/test_lfu.py

@@ -52,3 +52,15 @@ def test_lfu_getsizeof(self):
             cache[4] = 4
         self.assertEqual(len(cache), 1)
         self.assertEqual(cache[3], 3)
+
+    def test_lfu_update_existing(self):
+        cache = LFUCache(maxsize=2)
+
+        cache[1] = 1
+        cache[2] = 2
+        cache[1] = "updated"
+        cache[3] = 3
+
+        self.assertEqual(cache[1], "updated")
+        self.assertIn(3, cache)
+        self.assertNotIn(2, cache)

tests/test_lru.py

@@ -54,3 +54,15 @@ def test_lru_getsizeof(self):
             cache[4] = 4
         self.assertEqual(len(cache), 1)
         self.assertEqual(cache[3], 3)
+
+    def test_lru_update_existing(self):
+        cache = LRUCache(maxsize=2)
+
+        cache[1] = 1
+        cache[2] = 2
+        cache[1] = "updated"
+        cache[3] = 3
+
+        self.assertEqual(cache[1], "updated")
+        self.assertIn(3, cache)
+        self.assertNotIn(2, cache)

tests/test_rr.py

@@ -56,6 +56,18 @@ def test_rr_getsizeof(self):
         self.assertEqual(len(cache), 1)
         self.assertEqual(cache[3], 3)
 
+    def test_rr_update_existing(self):
+        cache = RRCache(maxsize=2, choice=min)
+
+        cache[1] = 1
+        cache[2] = 2
+        cache[1] = "updated"
+        cache[3] = 3
+
+        self.assertIn(2, cache)
+        self.assertIn(3, cache)
+        self.assertNotIn(1, cache)
+
     def test_rr_bad_choice(self):
         def bad_choice(seq):
             raise ValueError("test error")