Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CLI implementation #51

Closed
JakeStanger opened this issue Jan 8, 2022 · 5 comments
Closed

Better CLI implementation #51

JakeStanger opened this issue Jan 8, 2022 · 5 comments

Comments

@JakeStanger
Copy link
Collaborator

The current CLI is fine, but the need to be in the current directory for some operations is a little annoying. The current implementation also makes it difficult to expand for more features (such as the WatchConfig fields added in #49 ).

I would suggest initially migrating the current code to use Clap or similar.

Commands could then be updated to the something like the below format:

dura serve # can be left as-is

# these default to cwd
dura watch [dir] [--include <includes>] [--exclude <excludes>] [--max-depth <depth>]
dura unwatch [dir]
dura capture [dir]
@tkellogg
Copy link
Owner

tkellogg commented Jan 8, 2022

Definitely. This would be a huge improvement.

@drupol
Copy link
Collaborator

drupol commented Jan 8, 2022

Working on clap integration, working fine so far.

image

@drupol drupol mentioned this issue Jan 8, 2022
4 tasks
@tkellogg
Copy link
Owner

tkellogg commented Jan 8, 2022

@JakeStanger does this resolve the issue adequately?

@JakeStanger
Copy link
Collaborator Author

Absolutely, that's fantastic service! Awesome and very speedy work @drupol

@drupol
Copy link
Collaborator

drupol commented Jan 9, 2022

Thanks! It's the second time I do a PR for a rust project, I really like it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants