Skip to content

Updated MongoDB Driver and FSharp Runtime #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Updated MongoDB Driver and FSharp Runtime #9

wants to merge 11 commits into from

Conversation

nukedbit
Copy link

@nukedbit nukedbit commented Jul 1, 2015

Hi i have updated to new shining mongodb driver :), and also with the last F# runtime, let me know if you like it or if i should improve something

do
Serializers.Register()

interface System.IDisposable with
member this.Dispose() =
db.DropCollection "objects" |> ignore
db.DropCollection "persons" |> ignore
()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the unit here?

@tkellogg
Copy link
Owner

tkellogg commented Jul 7, 2015

Hi Sebastian,

I apologize for taking so long to get around to this PR. I'm not ready to merge this quite yet as there's a few outstanding issues I'd like to see resolved first.

I'm not particularly happy that one of the changes wipes out my name as owner. If you really intend to commit time to this project, I'm open to discussing what we can do, but I assure you that nothing of the sort will happen in this PR.

As for the other changes, I've just been skimming the code so I haven't been able to thoroughly read through the changes like I should. Still, there seems to be some issues I'd like to see resolved before this gets merged.

Thanks again for taking the time to contribute, I do appreciate the patience it takes.

@nukedbit
Copy link
Author

nukedbit commented Jul 7, 2015

Hi Tim
Don't worry for the timing i understand everyone has it's priorities :), sorry for the typos but i've been only one month on F# on a greenfield project,i can keep improve it on my fork based on your suggestion, and maybe with time we can merge it back, if you like to help me out figure out where i'm wrong :) we can work together, sorry for the owner error, i really meant to add me as author of the changes not as the owner.

@tkellogg
Copy link
Owner

tkellogg commented Jul 7, 2015

On further inspection, perhaps those async blocks in df0505c were a good idea. It just looked strange when I looked at them first -- up to you if you want to un-revert.

What you have looks pretty good, but it's also a major change so I'm going to take my time merging it in.

@nukedbit
Copy link
Author

nukedbit commented Jul 7, 2015

Yes they maybe can simply reading of code, but at the end the code is executed synchronously, maybe i could readd them later.
Yes is a very breaking change maybe we should publish it as a new version specifically for the new driver? currently i have renamed the package to MongoDB.Driver.FSharp so it can match the currently naming of the driver and also so i can use it internally without conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants