Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos arm64 build fail #172

Closed
zhuxiujia opened this issue Oct 23, 2023 · 8 comments
Closed

macos arm64 build fail #172

zhuxiujia opened this issue Oct 23, 2023 · 8 comments

Comments

@zhuxiujia
Copy link

error[E0423]: expected function, found macro `transmute`
   --> /Users/zxj/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.4/src/operations.rs:128:15
    |
128 |         xor ^ transmute::<_, u128>(vaesmcq_u8(vaeseq_u8(value, transmute!(0u128))))
    |               ^^^^^^^^^^^^^^^^^^^^ not a function
    |
help: use `!` to invoke the macro
    |
128 |         xor ^ transmute::<_, u128>!(vaesmcq_u8(vaeseq_u8(value, transmute!(0u128))))
    |                                   +
help: consider importing one of these items instead
    |
1   + use core::mem::transmute;
    |
1   + use zerocopy::macro_util::core_reexport::mem::transmute;
    |


@PureWhiteWu
Copy link
Contributor

Seems duplicate of #170 .
This title is a bit too sharp, every author/maintainer of open source projects should be respected since this is all FREE OF CHARGE, and the code works fine on amd64.
I think this is just because the maintainer doesn't have an aarch64 machine to test it currently, and this is not a big deal.
Keep in mind that you must use open source code AT YOUR OWN RISK.

@joshlf
Copy link
Contributor

joshlf commented Oct 23, 2023

A fix has been uploaded: #171

@schungx
Copy link
Contributor

schungx commented Oct 23, 2023

This title is a bit too sharp

Agree. And almost no info is provided as to O/S version, CPU etc. The title is obnoxious.

@tkaitchuck
Copy link
Owner

Fix published

@zhuxiujia
Copy link
Author

Seems duplicate of #170 . This title is a bit too sharp, every author/maintainer of open source projects should be respected since this is all FREE OF CHARGE, and the code works fine on amd64. I think this is just because the maintainer doesn't have an aarch64 machine to test it currently, and this is not a big deal. Keep in mind that you must use open source code AT YOUR OWN RISK.

I didn't make it clear that my device is arm64。
be sorry,Because this library has affected many library compilation failures, I hope the author can add more testing machines。

Or use a more general implementation method, otherwise causing a large number of users to fail compilation will make people angry

@zhuxiujia
Copy link
Author

I strongly recommend that if there are significant changes, the version number should be modified instead of simply causing the existing version to fail compilation or worse things to happen

@schungx
Copy link
Contributor

schungx commented Oct 25, 2023

causing a large number of users to fail compilation will make people angry

In that case, I suggest that you keep your anger in control. Remember that you're not paying any money for this. This is free stuff and you have no right to be angry at a volunteer.

@PureWhiteWu
Copy link
Contributor

And also, if you are angry, you have the right to choose not to use open source projects. You can write it and maintain it by yourself.

@zhuxiujia zhuxiujia changed the title did you test code? macos arm64 build fail Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants