Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMostRecentWindowEntries() is a mix of UI & logical code #6

Open
tjk213 opened this issue Sep 29, 2022 · 0 comments
Open

getMostRecentWindowEntries() is a mix of UI & logical code #6

tjk213 opened this issue Sep 29, 2022 · 0 comments
Labels
Implementation Enhancement Improves maintainability of codebase.

Comments

@tjk213
Copy link
Owner

tjk213 commented Sep 29, 2022

getMostRecentWindowEntries() retrieves the data for the last entry in each Rolling-ROI sheet. This is used to generate a table in the summary email that looks like this:

Last 4 years:	195.69%	(2.96X)
     3 years:	141.66%	(2.42X)
     2 years:	81.94%	(1.82X)
     1 years:	-52.60%	(0.47X)

The choice to only put the word last on the first line is a UI design decision, and should therefore live in a UI codeblock (e.g., in the HTML file), not in getMostRecentWindowEntries(). getMostRecentWindowEntries() should not need a special codepath for this - it should simply return the data.

@tjk213 tjk213 added Implementation Enhancement Improves maintainability of codebase. 💰 Offering a bounty of 200,000 sats for solution. and removed 💰 Offering a bounty of 200,000 sats for solution. labels Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Enhancement Improves maintainability of codebase.
Projects
None yet
Development

No branches or pull requests

1 participant