Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await player to be destroyed before re-creating it #357

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: await player to be destroyed before re-creating it #357

merged 2 commits into from
May 25, 2022

Conversation

victoragnez
Copy link
Contributor

To make it compatible with Strict Mode of React 18

Closes #355

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 23, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 575e8cd:

Sandbox Source
react-youtube-example Configuration

ruisaraiva19
ruisaraiva19 requested changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@ruisaraiva19 ruisaraiva19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoragnez Thanks for the contribution.

Please take a look at my suggestions and let me know if you have any questions.

packages/react-youtube/src/YouTube.tsx Outdated Show resolved Hide resolved
packages/react-youtube/src/YouTube.tsx Outdated Show resolved Hide resolved
packages/react-youtube/src/YouTube.tsx Outdated Show resolved Hide resolved
@henninghaakonsen
Copy link

Great fix - our team is also having issues with this.

@ruisaraiva19 ruisaraiva19 merged commit b519d59 into tjallingt:canary May 25, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version react-youtube-v9.0.1-canary.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version react-youtube-v9.0.2-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version react-youtube-v9.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruisaraiva19 ruisaraiva19 ruisaraiva19 approved these changes

Assignees
No one assigned
Labels
Status: Released Type: Hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Youtube component disappearing immediately after page loads
3 participants
@victoragnez @henninghaakonsen @ruisaraiva19