Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change has been manually cherry-picked from #1919 so that it can be discussed independently.
Problem
#1919 (comment)
#1919 (comment)
#1919 (comment)
Solution
Compared with the original solution from #1919 (see 7fd0b22...52d5885), the one suggested here keeps
OptionValueSource
as an exported type (could be used in subclasses to narrow down the allowed custom sources) and uses theOptionValueSource | string
union instead of juststring
for additional clarity.ChangeLog
Fixed
undefined
and arbitrary custom source strings are allowed now)Peer PRs
Changes are to be merged into…
parse()
/parseAsync()
#1919