-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.0.0 release #1683
Merged
Merged
9.0.0 release #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify how default program name found. Just use args. * Rework search for executable files * Adjust error messaging, still WIP * Add executableDir and use searching for subcommands * Wording improvements * Add TypeScript for nameFromFilename * Add new tests for name (and nameFromFilename) * Add TypeScript for executableDir * Start tests for subcommand search * Comment-out unused routine for lint, WIP * Refactor tests and skip launchable executable tests on Windows * Add notes on further tests * Filling out mock executable tests * Expand tests * Remove debugging and ToDo * Relative and absolute test for executableDir * Avoid memory leak warning * Fix relative search test * Separate and expand .name section in README. And some lint, remove trailing spaces et al * Add .name to multiple subcommand example * Update description of executable search. Add mention of .executableDir * Add coverage of naming subcommands.
* FIrst try at exports in package.json * Set required version for conditional export in package.json * Update README with export support
* Add defaultOption, but not implemented * Start refactoring addOption to clarify logic * Update comments * Implement separate default and preset for options * Changed behaviour of boolean default, fix and extend test * Update unit tests with new default/preset behaviour * Add tests for default with all option types * Add tests that default does get overwritten * Fix JSDoc for new routines * Add tests for preset * Add typings * Update README * Add test of preset with negated * Update comments * Add tests of options being used twice * Modify documentation for preset * Add prefix example usage in README * Add preset to help * Update code example * Use same format for preset as for default, add test * Be selective about default and preset shown in help
* Throw error for wrong argument to option or requiredOption * Make test and error message more specific
* Update package-lock.json to lockfile@2 * Update Jest * Update Jest * Update @types/node * Update standard
* Quick Start * Update comments * Update quick start examples so README and code match
…c() (#1669) * Make .aliases() param readonly * Make .parse() and .parseAsync() param readonly in TypeScript
* Add eslint-config-standard peer dependencies explicitly * Remove unused eslint customisation, closer to standard * Configure eslint with no-extra-semi, as per semistandard * Use standard-with-typescript again now installing dependencies * Fix linting for undefined property * Run js and rs lint by default for `npm run lint`
* Allow readonly array as parameter of .choices() Without `readonly`, readonly arrays cannot be passed as parameters. Example: https://www.typescriptlang.org/play?#code/GYVwdgxgLglg9mABMAjACgIYCcsC5EDOUWMYA5gNoC6AlIgN4C+AUKJLAsgEyY75YBTDABMEAGwCehYqUq0GLZhARFE2LCkQBeRBQDkGPVQDcSlVDU4u23QaNqCiZWCKnW6dShqngPT9-deLC4A3yCQ4yA * Add tests for .choices() typings * Take a defensive copy of .choices argument to make sure it's readonly * Expand choices tests to cover readonly contract (#1) * Use the defensive copy of the parameter of .choices() in parseArg Co-authored-by: John Gee <john@ruru.gen.nz>
* Proof of concept * Use separate method for optsWithGlobals * Add documentation * Add tests * Simplify description * Add example * Remove unused param
* Refactor private _displayError() into public error() * add TypeScript * Add tests * Add to README * Tiny wording change
abetomo
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9️⃣
I tried to run "Rebase and merge", but it says "This branch cannot be rebased due to conflicts" and I can't merge on the web. |
Ordinary merge is fine. Done! |
Thanks 🚀 |
Woop woop! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CHANGELOG and version number ready for 9.0.0 release. Have not tagged.
Reminder: don't do a squash (we want the commits for each PR). Mentioning it because I get in the habit!