Improve 2.x executable subcommand tracking and update dependencies (#…

…1059) * Improve executable subcommand tracking * Update dev dependencies * Add 2.20.1 to CHANGELOG * 2.20.1
tj · Sep 28, 2019 · 48b02f0 · 48b02f0
1 parent 3e8bf54
commit 48b02f0
Show file tree

Hide file tree

Showing 4 changed files with 852 additions and 727 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+2.20.1 / 2019-09-29
+==================
+
+  * Improve executable subcommand tracking
+  * Update dev dependencies
 
 2.20.0 / 2019-04-02
 ==================

diff --git a/index.js b/index.js
@@ -99,7 +99,7 @@ Option.prototype.is = function(arg) {
 function Command(name) {
   this.commands = [];
   this.options = [];
-  this._execs = {};
+  this._execs = new Set();
   this._allowUnknownOption = false;
   this._args = [];
   this._name = name || '';
@@ -178,7 +178,7 @@ Command.prototype.command = function(name, desc, opts) {
   if (desc) {
     cmd.description(desc);
     this.executables = true;
-    this._execs[cmd._name] = true;
+    this._execs.add(cmd._name);
     if (opts.isDefault) this.defaultExecutable = cmd._name;
   }
   cmd._noHelp = !!opts.noHelp;
@@ -484,7 +484,7 @@ Command.prototype.parse = function(argv) {
     })[0];
   }
 
-  if (this._execs[name] && typeof this._execs[name] !== 'function') {
+  if (this._execs.has(name)) {
     return this.executeSubCommand(argv, args, parsed.unknown);
   } else if (aliasCommand) {
     // is alias of a subCommand