Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to 2.7 forces to change the app language to chinese and there's no way to change it back to english. #528

Closed
5 of 6 tasks
hyperphysin opened this issue May 1, 2024 · 14 comments
Assignees
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available

Comments

@hyperphysin
Copy link

Please confirm the following:

  • Be sure to check out FAQ
  • I have carefully read the README
  • I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version
  • I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Problem description

updating to 2.7 forces to change the app language to chinese and there's no way to change it back to english.

Is the issue consistently reproducible?

Reproducible

Steps to Reproduce

just update it

Screenshot

Screenshot 2024-05-01 at 11 10 09 AM

Expected result

I want it to be in english!

Proposed solution (optional)

No response

Device type and OS version

apple m2 air, sonoma

Are you willing to submit a PR to fix this issue?

  • I'm willing to submit a PR
@hyperphysin hyperphysin added the bug Something isn't working label May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Hello hyperphysin, Thank you for your first issue contribution 🎉

@tisfeng
Copy link
Owner

tisfeng commented May 1, 2024

Please try to change app language manually.

image

@tisfeng
Copy link
Owner

tisfeng commented May 1, 2024

@choykarl If you have time, please take a look at this issue and see if it modifies the user's App language?

@thesla13
Copy link

thesla13 commented May 1, 2024

Hey, @tisfeng! I have the same issue @choykarl does.

The thing is the settings page looks nothing like the one in your screenshot. It never did look that way for me in previous versions either. It always looked like this:

snap 2024 05 01 07-06-25

And there doesn't seem to be an option to change the interface language. In your screenshot it's directly above the appearance setting, while there is nothing above the "外观" setting in the layout I happen to have.

I am very much confused, honestly ((

@tisfeng
Copy link
Owner

tisfeng commented May 1, 2024

We rewrote the settings page using SwiftUI and added many new features, such as app language switching, but this part of SwiftUI functionality requires macOS 13.0+.

If your computer system is macOS 13.0+, the settings page will have the SwiftUI App option. Please enable it and then restart Easydict.

image

@Diane-Best
Copy link

image
下载最新版2。7.0安装时 报错

@tisfeng
Copy link
Owner

tisfeng commented May 2, 2024

最近我们并没有更改相关的代码,可能是苹果的安全认证又变严格了 🫠

请尝试:设置-隐私与安全性-仍要打开 Easydict

image

@thesla13
Copy link

thesla13 commented May 2, 2024

Hey, @tisfeng! Thanks for the reply!

I've switched to the SwiftUI version, it launched in Chinese, but the settings pane became just like in your screenshot, the language switch was right there, and everything is quite perfect now. Thank you!

Except for one minor thing. I use AltTab window switcher instead of macOS' built-in one. It mimics the way window switching works in Windows listing all the apps' windows instead of switching between apps. And while there is nothing unusual to be seen in Mission Control, AltTab's window switching pane shows a stray faceless window called "Go to Settings" and carrying EasyDict's icon. It's there whenever ED is running: I quit it — the window goes away; launch it again — it reappears.

snap 2024 05 02 04-19-18
snap 2024 05 02 04-22-21

Could you please look into this?

Thank you so much for your hard work!

@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label May 2, 2024
@tisfeng
Copy link
Owner

tisfeng commented May 4, 2024

@thesla13 We've fixed the language issue #530 .

I'm not using AltTab, we'll check on this issue later.

@thesla13
Copy link

thesla13 commented May 4, 2024

@tisfeng

I've looked a bit closer, and it's not just AltTab. The stray interface-less Easydict window is there in Mission Control as well. Admittedly, you have to look for it, but it is there, and for no good reason.

snap 2024 05 03 02-31-20
snap 2024 05 03 02-02-19

@tisfeng
Copy link
Owner

tisfeng commented May 5, 2024

Thanks for your feedback, I checked the code and it is indeed a bug, we will fix it later.

@tisfeng
Copy link
Owner

tisfeng commented May 7, 2024

The problem is probably caused by this code.

@AkaShark Could you take a look at it?

Window("go_to_settings", id: "go_to_settings") {

@AkaShark
Copy link
Collaborator

AkaShark commented May 7, 2024

The problem is probably caused by this code.该问题可能是由这段代码引起的。

@AkaShark Could you take a look at it? 你能看一下吗?

Window("go_to_settings", id: "go_to_settings") {

Sure, I'll check the code later.

@tisfeng
Copy link
Owner

tisfeng commented May 12, 2024

This issue has been fixed in version 2.7.2.

@tisfeng tisfeng closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

6 participants