Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 功能建议:支持繁体中文 #228

Closed
3 of 4 tasks
tisfeng opened this issue Nov 18, 2023 · 10 comments · Fixed by #650
Closed
3 of 4 tasks

🚀 功能建议:支持繁体中文 #228

tisfeng opened this issue Nov 18, 2023 · 10 comments · Fixed by #650
Assignees
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available localization

Comments

@tisfeng
Copy link
Owner

tisfeng commented Nov 18, 2023

请先确认以下事项

  • 已仔细阅读了 README
  • issues 页面搜索过(包括已关闭的 issue),未发现类似功能建议
  • Easydict 已升级到最新版本

功能描述

我看了一下,除了简中和英文,似乎使用繁体中文的用户也挺多,感觉可以支持。

使用场景(可选)

No response

实现方案(可选)

No response

是否愿意提交 PR 实现该功能

  • 我愿意提交 PR!
@tisfeng tisfeng added the enhancement New feature or request label Nov 18, 2023
@tisfeng
Copy link
Owner Author

tisfeng commented Nov 18, 2023

@Jerry23011 你那边腾讯翻译做完了吗,如果完成了,有空可以做一下这个。

@Jerry23011
Copy link
Collaborator

还没有,不过本地化流程我很熟悉,干脆直接另开一个 issue 找人做本地化好了,回头我再写一些文档

@tisfeng
Copy link
Owner Author

tisfeng commented Nov 19, 2023

这样也行,不过我有点担心非苹果开发者可能对 String Catalog 和 Xcode 的操作不熟悉。

如果可以,我希望你稍后能提供一个 Easydict 支持繁体中文的 PR 示范,然后关联到 #229 ,方便其他人参考。

@Jerry23011
Copy link
Collaborator

繁体中文说实话我觉得我不太能胜任,一些术语上差得还是挺大的
我正好完成了一个文档,已经PR,不过我可以做一个Canadian English的PR作为以后的参考

@tisfeng
Copy link
Owner Author

tisfeng commented Nov 19, 2023

也可以。

后面繁体中文本地化,可以找一下这几位用户
https://github.com/tisfeng/Easydict/issues?q=is%3Aissue+%E7%B9%81%E4%BD%93+is%3Aclosed ,之前提过繁体有关的需求,可以征求一下他们的意见。

@tisfeng
Copy link
Owner Author

tisfeng commented Nov 20, 2023

由于本地化的改动暂时不适合合并到主分支 #231 (comment) ,我新建了一个 localization 分支,后续关于本地化的 PR 请都提交到这个分支上。

@tisfeng
Copy link
Owner Author

tisfeng commented Aug 12, 2024

目前设置页早已用 SwiftUI 重写,现在可以很方便支持各个语言本地化了,也不需要另外使用 localization 分支,就在最新的 dev 分支就行。

@Jerry23011 你有空可以接手一下这个吗

@Jerry23011
Copy link
Collaborator

OK,我来 migrate 一下

@Jerry23011 Jerry23011 self-assigned this Aug 12, 2024
@Jerry23011 Jerry23011 linked a pull request Aug 18, 2024 that will close this issue
2 tasks
@Jerry23011
Copy link
Collaborator

I redid the Traditional Chinese localization with ChatGPT and Claude in #650. These two models performed well with appropriate prompts.

@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Aug 23, 2024
@tisfeng
Copy link
Owner Author

tisfeng commented Sep 15, 2024

你好,2.9.0 版本已添加该功能。

@tisfeng tisfeng closed this as completed Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available localization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants