Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and Benchmark names are too generic #360

Open
gaby opened this issue Sep 15, 2024 · 0 comments
Open

Test and Benchmark names are too generic #360

gaby opened this issue Sep 15, 2024 · 0 comments

Comments

@gaby
Copy link

gaby commented Sep 15, 2024

When using msgp for multiple structures in one big code base all the benchmarks are generated with the same name, while this doesn't cause an issue it makes comparing Previous/Current benchmarks impossible.

For example: BenchmarkAppendMsgitem()

When running with go test ./... -benchmem -run=^$ -bench . we get multiple entries with the same benchmark name even though the code are in different folders. Ideally msgp would add a cli flag that allows to specify a name to be appending after the word Benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant