fix(rp2350): port USB SetAddressRequest using hardware timer to rp2350

Author: rdon

src/machine/machine_rp2350_usb.go

@@ -172,21 +172,20 @@ func initEndpoint(ep, config uint32) {
 }
 
 func handleUSBSetAddress(setup usb.Setup) bool {
+	rp.USB.SIE_STATUS.Set(rp.USB_SIE_STATUS_ACK_REC)
 	sendUSBPacket(0, []byte{}, 0)
 
-	// last, set the device address to that requested by host
-	// wait for transfer to complete
-	timeout := 3000
-	rp.USB.SIE_STATUS.Set(rp.USB_SIE_STATUS_ACK_REC)
-	for (rp.USB.SIE_STATUS.Get() & rp.USB_SIE_STATUS_ACK_REC) == 0 {
-		timeout--
-		if timeout == 0 {
-			return true
-		}
+	// Wait for transfer to complete with a timeout.
+	// Using 570μs timeout which is exactly the same as SAMD21.
+
+	if !timer.waitUntil(func() bool {
+		return (rp.USB.SIE_STATUS.Get() & rp.USB_SIE_STATUS_ACK_REC) != 0
+	}, 570) {
+		return false
 	}
 
+	// Set the device address to that requested by host.
 	rp.USB.ADDR_ENDP.Set(uint32(setup.WValueL) & rp.USB_ADDR_ENDP_ADDRESS_Msk)
-
 	return true
 }